Summary

Probe functions and writeSandboxConfigSyncFile construct temp filenames using Date.now() and Math.random(), both of which are predictable. A local attacker can race the file creation with a symlink to redirect curl output (API responses) or inject a malicious sync script. This replaces all 6 sites with fs.mkdtempSync(), matching the secure pattern already used elsewhere in the same file.

Related Issue

Closes #1093

Changes

• Replaced predictable temp filename construction in 6 functions with fs.mkdtempSync():
  • writeSandboxConfigSyncFile — now creates nemoclaw-sync-<random>/sync.sh
  • probeOpenAiLikeEndpoint — now creates nemoclaw-probe-<random>/body.json
  • probeAnthropicEndpoint — now creates nemoclaw-anthropic-probe-<random>/body.json
  • fetchNvidiaEndpointModels — now creates nemoclaw-nvidia-models-<random>/body.json
  • fetchOpenAiLikeModels — now creates nemoclaw-openai-models-<random>/body.json
  • fetchAnthropicModels — now creates nemoclaw-anthropic-models-<random>/body.json
• Updated all finally blocks to clean up the temp directory ({ recursive: true }) instead of just the file.
• Updated caller in setupOpenclaw to remove the temp directory instead of unlinking the file.
• Updated existing test to match new function signature and verify file permissions (0o600).

Testing

• npm test passes (no local environment)
• Unit tests updated

Executed:

• Verified all 6 mkdtempSync calls use the correct prefix to preserve debuggability
• Verified all 5 finally blocks reference probeDir (not bodyFile) for recursive cleanup
• Verified writeSandboxConfigSyncFile caller at line 2373 cleans up via path.dirname(scriptFile)
• Confirmed fs.mkdtempSync is already used at lines 1764 and 2680 in the same file — no new API dependency

Checklist

• Follows Conventional Commits
• Commits are signed

Summary by CodeRabbit

• Chores

  • Use isolated per-invocation temporary directories for sandbox config and HTTP probe/model fetch operations, writing stable script/output filenames and performing recursive cleanup to improve reliability and avoid collisions; ensure generated scripts have secure permissions.

• Tests

  • Updated tests to verify the new temp-directory layout, script placement, and file permission behavior.